feat(desktop): add opt-in Cua Driver computer use - #5533
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Reviewed the new Cua driver Effect code (apps/desktop/src/cua/CuaDriverServerEnvironment.ts, apps/server/src/cua/CuaDriverEmbedded.ts) and the touched call sites against the Effect service conventions. Error classes use Schema.TaggedErrorClass with structural attributes and real cause, failures are recovered with Effect.catchTags, and imports use effect/* namespaces — no Layer.succeed, ManagedRuntime.make, or runPromise misuse was introduced. One convention issue: the new startup handlers stringify the underlying defect into the log payload instead of passing it through as cause.
Posted via Macroscope — Effect Service Conventions
Problem
T3 Code does not currently expose an opt-in path for Codex agents to use the packaged Cua Driver integration. The original contribution in #4354 contains the intended implementation, but its branch history diverged from
t3code/codex-turn-mapping, producing conflicts and an inflated 241-commit, 821-file comparison.This PR rebuilds that contribution on the current target branch. It replays the Cua-only commit stack from injaneity's #4354, preserves the original commit authorship, and adds one small compatibility fix required by the current desktop startup graph.
Solution
The rebuilt comparison is 17 commits across 19 files, rather than the unrelated 821-file diff on #4354.
Validation
pnpm exec vp test run apps/desktop/src/cua/CuaDriverServerEnvironment.test.ts apps/desktop/src/settings/DesktopClientSettings.test.ts apps/server/src/cua/CuaDriverEmbedded.test.ts apps/server/src/orchestration-v2/Adapters/CodexAdapterV2.test.ts apps/server/src/provider/Layers/codexLaunchArgs.test.ts packages/contracts/src/settings.test.ts scripts/build-desktop-artifact.test.ts— 144 tests passed@t3tools/desktop,t3,@t3tools/web,@t3tools/contracts, and@t3tools/scriptsgit diff --checkpassesScreenshots
Enabled:
Disabled:
Built with GPT-5 Codex in the Codex desktop harness.