Skip to content

fix(web): show Stop button while input is pending - #5554

Open
ipanasenko wants to merge 2 commits into
pingdotgg:mainfrom
ipanasenko:fix/pending-user-input-stop
Open

fix(web): show Stop button while input is pending#5554
ipanasenko wants to merge 2 commits into
pingdotgg:mainfrom
ipanasenko:fix/pending-user-input-stop

Conversation

@ipanasenko

@ipanasenko ipanasenko commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

A running turn that asks for user input replaces the normal composer actions, which hides the Stop control even though settling instructs the user to interrupt first:

image

Bringing the Stop button back:

image

Mobile app already shows Stop button in this case:

image

Reuse the existing Stop generation control beside the pending question actions while the turn is running. Size it to match the adjacent small action on desktop while preserving the existing standalone Stop size. Add focused render coverage for visibility and both size contexts.

Model: GPT-5.6 Sol
Harness: Codex in T3 Code

Note

Show Stop button while a pending action is present in ComposerPrimaryActions

Previously, the Stop generation button only appeared when isRunning was true and no pending action existed. Now it also renders inside the pending action branch when isRunning is true, so users can interrupt generation in both states.

  • Extracts a renderStopGenerationButton helper in ComposerPrimaryActions.tsx to centralize the button markup.
  • The button uses sm:size-7 sizing when inside a pending action and sm:h-8 sm:w-8 when standalone, so the visual size differs slightly between the two states.
  • Adds tests covering the new rendering paths in ComposerPrimaryActions.test.ts.

Macroscope summarized 5420ca8.


Note

Low Risk
Composer UI and interrupt wiring only; no auth, data, or API changes.

Overview
When a turn is still running but the composer shows pending user-input actions (submit/next), users can Stop generation again instead of losing that control.

ComposerPrimaryActions pulls the stop control into a shared renderStopGenerationButton helper and renders it beside pending actions when isRunning is true. The in-pending variant uses size-8 sm:size-7 so it lines up with the small adjacent buttons; the standalone running-only stop keeps size-8 sm:h-8 sm:w-8.

Tests use static markup renders with mocks to assert stop visibility with/without a running turn and that both size contexts stay correct.

Reviewed by Cursor Bugbot for commit 5420ca8. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d5f74d67-2068-430d-bfcd-6dde87b3d613

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions github-actions Bot added vouch:unvouched PR author is not yet trusted in the VOUCHED list. size:M 30-99 changed lines (additions + deletions). labels Aug 6, 2026
@ipanasenko ipanasenko changed the title fix(web): show stop while input is pending fix(web): show Stop button while input is pending Aug 6, 2026
@ipanasenko
ipanasenko marked this pull request as ready for review August 6, 2026 23:34
@macroscopeapp

macroscopeapp Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved 5420ca8

Simple UI fix that adds visibility of an existing Stop button during pending input states. The change extracts existing button code into a helper function and adds one conditional render, with comprehensive tests. Self-contained with clear intent and limited scope.

You can customize Macroscope's approvability policy. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30-99 changed lines (additions + deletions). vouch:unvouched PR author is not yet trusted in the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant