fix(web): show Stop button while input is pending - #5554
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ApprovabilityVerdict: Approved 5420ca8 Simple UI fix that adds visibility of an existing Stop button during pending input states. The change extracts existing button code into a helper function and adds one conditional render, with comprehensive tests. Self-contained with clear intent and limited scope. You can customize Macroscope's approvability policy. Learn more. |
A running turn that asks for user input replaces the normal composer actions, which hides the Stop control even though settling instructs the user to interrupt first:
Bringing the Stop button back:
Mobile app already shows Stop button in this case:
Reuse the existing Stop generation control beside the pending question actions while the turn is running. Size it to match the adjacent small action on desktop while preserving the existing standalone Stop size. Add focused render coverage for visibility and both size contexts.
Model: GPT-5.6 Sol
Harness: Codex in T3 Code
Note
Show Stop button while a pending action is present in
ComposerPrimaryActionsPreviously, the Stop generation button only appeared when
isRunningwas true and no pending action existed. Now it also renders inside the pending action branch whenisRunningis true, so users can interrupt generation in both states.renderStopGenerationButtonhelper inComposerPrimaryActions.tsxto centralize the button markup.sm:size-7sizing when inside a pending action andsm:h-8 sm:w-8when standalone, so the visual size differs slightly between the two states.ComposerPrimaryActions.test.ts.Macroscope summarized 5420ca8.
Note
Low Risk
Composer UI and interrupt wiring only; no auth, data, or API changes.
Overview
When a turn is still running but the composer shows pending user-input actions (submit/next), users can Stop generation again instead of losing that control.
ComposerPrimaryActionspulls the stop control into a sharedrenderStopGenerationButtonhelper and renders it beside pending actions whenisRunningis true. The in-pending variant usessize-8 sm:size-7so it lines up with the small adjacent buttons; the standalone running-only stop keepssize-8 sm:h-8 sm:w-8.Tests use static markup renders with mocks to assert stop visibility with/without a running turn and that both size contexts stay correct.
Reviewed by Cursor Bugbot for commit 5420ca8. Bugbot is set up for automated code reviews on this repo. Configure here.