fix: add end-to-end flush semantics for flush(cb)#198
Merged
Conversation
Implement cross-thread FLUSH/FLUSHED protocol so ThreadStream#flush(cb) waits for worker destination flush. - add context-scoped FLUSH request/ack handling between main thread and worker - queue and resolve pending flush callbacks by id - fail pending flush callbacks on worker exit/destroy - support worker destination flush via flush(cb)/flushSync()/drain fallback - add tests for flush behavior and worker-exit failure path - add missing flush(cb?) type signature and document stronger flush semantics Fixes #197
Register FLUSH control listener only after worker setup completes and guard flush requests until ready.
This prevents the internal FLUSH channel from racing with userland parentPort.once('message') handlers (e.g. post-message test), while preserving context-scoped control messages.
jsumners
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #197 by making
ThreadStream#flush(cb)wait for end-to-end worker destination flush, not only shared-buffer drain.Changes
{ code: 'FLUSH', context: 'thread-stream', id }{ code: 'FLUSHED', context: 'thread-stream', id }flush(cb)now:destination.flush(cb)(including promise/sync variants)destination.flushSync()drainwhen backpressuredflush(cb?)declaration inindex.d.ts.Validation
npm run lintnpm run test:cinpm run buildFixes #197