Read reception reports from sender report packets#417
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #417 +/- ##
==========================================
+ Coverage 80.07% 80.12% +0.04%
==========================================
Files 88 88
Lines 4602 4603 +1
==========================================
+ Hits 3685 3688 +3
+ Misses 734 733 -1
+ Partials 183 182 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mengelbart
force-pushed
the
fix/stats-interceptor
branch
from
0b7d377 to
40218f3
Compare
JoTurk
approved these changes
Jun 2, 2026
Comment on lines
+239
to
+244
| func (r *recorder) recordIncomingRR( | ||
| latestStats internalStats, | ||
| reports []rtcp.ReceptionReport, | ||
| ts time.Time, | ||
| ) internalStats { | ||
| for _, report := range reports { |
Member
There was a problem hiding this comment.
question should we check if the report.ssrc matches the recorder ssrc?
Contributor
Author
There was a problem hiding this comment.
Good point, we probably should. I think this is also relevant for the other RTCP packet types, though. I will create a separate issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for reading reception reports blocks from Sender Reports.
Reference issue
Fixes #412