Remove factor 8 from pacing burst size#418
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #418 +/- ##
=======================================
Coverage 80.01% 80.01%
=======================================
Files 88 88
Lines 4608 4608
=======================================
Hits 3687 3687
Misses 737 737
Partials 184 184
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mengelbart
force-pushed
the
fix/pacing-factor
branch
3 times, most recently
from
710fd1a to
b0a48bf
Compare
JoTurk
approved these changes
Jun 3, 2026
mengelbart
force-pushed
the
fix/pacing-factor
branch
from
b0a48bf to
40bf2d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the factor 8 from pacing bursts because burst size is already calculated in bits, not bytes. Instead, I added a min burst size to allow at least one packet to be sent.
Reference issue
Fixes #408