Skip to content

Filter incoming reports by SSRC#420

Merged
mengelbart merged 1 commit into
mainfrom
fix/stats-interceptor-ssrc
Jun 2, 2026
Merged

Filter incoming reports by SSRC#420
mengelbart merged 1 commit into
mainfrom
fix/stats-interceptor-ssrc

Conversation

@mengelbart

Copy link
Copy Markdown
Contributor

Description

Filtering reports by SSRC. Most important for Sender Reports, Receiver Reports, and Extended Reports. The others should be filtered earlier, but just to be sure, I also added a check for the correct MediaSSRCs of NACK, PLI, and FIR.

Reference issue

Fixes #419

@mengelbart mengelbart requested a review from JoTurk June 2, 2026 10:56
@mengelbart mengelbart force-pushed the fix/stats-interceptor-ssrc branch from e2d8a13 to b75ece5 Compare June 2, 2026 10:58
@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.09%. Comparing base (9f43161) to head (b75ece5).

Files with missing lines Patch % Lines
pkg/stats/stats_recorder.go 33.33% 5 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (33.33%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #420      +/-   ##
==========================================
+ Coverage   80.07%   80.09%   +0.02%     
==========================================
  Files          88       88              
  Lines        4603     4608       +5     
==========================================
+ Hits         3686     3691       +5     
- Misses        734      735       +1     
+ Partials      183      182       -1     
Flag Coverage Δ
go 80.09% <33.33%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mengelbart mengelbart merged commit e29c4f0 into main Jun 2, 2026
18 of 19 checks passed
@mengelbart mengelbart deleted the fix/stats-interceptor-ssrc branch June 2, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Stats recorder should filter incoming RTCP packets by SSRC

2 participants