Add Gulp globally, Test ngrok, Add dynamic cypress.json write#6
Open
leighs-hammer wants to merge 1 commit intopixelcabin:masterfrom
Open
Add Gulp globally, Test ngrok, Add dynamic cypress.json write#6leighs-hammer wants to merge 1 commit intopixelcabin:masterfrom
leighs-hammer wants to merge 1 commit intopixelcabin:masterfrom
Conversation
Alos adds a cypress.json overwrite for if the SHOPIFY_URL is passed in from travis. - Add grunt CLI globally - Travis dynamically write cypress.json - Reference usage of the GUI in travis for handling variables. - leave comments suggesting using env var for SHOPIFY_URL
leighs-hammer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alos adds a cypress.json overwrite for if the SHOPIFY_URL is passed in
from travis.
Pull request for: PivotalTracker
Description
To fix the travis builds on the source repository, checked the configs revised some timings to reduce the calls to an api that is unlikely to be ready.
Issue : Test Theme ID == null #2
Suggested moving SHOPIFY_URL to travis env vars, and comment to remove or comment out the definition of such in the config. The reasoning behind this is that as env vars are per branch targets can be switched without multiple configs or neededing to edit config code.
Note: while testing I noticed that ngrok at present fails with no errors, this is fragile.