[Aikido] Fix 17 critical issues in form-data, @actions/github, @slack/web-api and 4 more#4
Closed
aikido-autofix[bot] wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
CVE-2025-25288 in @octokit/plugin-paginate-rest - low severity
@octokit/plugin-paginate-rest is the Octokit plugin to paginate REST API endpoint responses. For versions starting in 1.0.0 and prior to 11.4.1 of the npm package @octokit/plugin-paginate-rest, when calling octokit.paginate.iterator(), a specially crafted octokit instance—particularly with a malicious link parameter in the headers section of the request—can trigger a ReDoS attack. Version 11.4.1 contains a fix for the issue.
Details
Remediation Aikido suggests bumping this package to version 9.2.2 to resolve this issue
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
Author
|
Closed by Aikido: a new AutoFix has been created → #5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade dependencies to fix critical RCE vulnerability in Axios via prototype pollution gadget chain, DoS in Axios mergeConfig, HTTP Parameter Pollution in form-data, and prototype pollution in lodash. This update includes breaking changes that require manual migration.
Breaking Change: Removed functionality that removed the Content-Type request header when passing FormData (v0.27.0)
Where your code is affected:
dist/index.js(WebClient class in @slack/web-api package, lines around axios initialization and serializeApiCallOptions method)Impact: The
@slack/web-apipackage (v5.10.0) bundled indist/index.jsexplicitly deletes theContent-Typeheader for POST requests (delete this.axios.defaults.headers.post['Content-Type']) and relies on axios to automatically set the correctContent-Typeheader when FormData is passed. In axios 0.27.0+, this automatic removal behavior was changed. The code creates FormData instances usingform-datapackage and copies headers fromform.getHeaders()into the request headers. However, since the default POST Content-Type is deleted, there may be conflicts or missing headers if axios no longer automatically handles FormData Content-Type removal.Remediation: Verify that the Content-Type header handling in the serializeApiCallOptions method properly sets multipart/form-data headers from form.getHeaders() before axios processes the request, or update the axios configuration to ensure Content-Type is properly managed for FormData requests.
Breaking Change: Refactored error handling implementing AxiosError as a constructor (v0.27.0)
Where your code is affected:
dist/index.js(error handling in WebClient's makeRequest method and general error handling throughout the bundled code)Impact: The code checks
error.isAxiosErrorproperty in the bundled axios code. The refactoring of AxiosError as a constructor in v0.27.0 may change how errors are instantiated and their properties are set, potentially affecting error detection and handling logic.Remediation: Review error handling code to ensure it properly handles the new AxiosError constructor pattern and verify that error.isAxiosError checks still work correctly with the refactored error handling.
form-data (2.5.1 => 2.5.4)
Breaking Change: setBoundary() method now validates boundary type (v2.5.4)
Where your code is affected: Not directly affected - no calls to
setBoundary()found in the codebaseImpact: The code uses
form.getHeaders()andform.append()methods but does not callsetBoundary()directly, so this validation change does not affect the codebase.Remediation: No action required for this specific change.
All breaking changes by upgrading axios from version 0.19.2 to 0.31.0 (CHANGELOG)
✅ 17 CVEs resolved by this upgrade, including 1 critical 🚨 CVE
This PR will resolve the following CVEs:
allowAbsoluteUrlsnot being set tofalseby default inbuildFullPath(), allowing attackers to bypass URL restrictions and process unintended URLs.formDataToJSONfunction allows attackers to manipulate object properties. Additionally, a ReDoS vulnerability incombineURLscan cause denial of service through malicious input.This issue affects form-data: < 2.5.4, 3.0.0 - 3.0.3, 4.0.0 - 4.0.3.