[Aikido] Fix 30 critical issues in form-data, @actions/github, @slack/web-api and 4 more#8
Open
aikido-autofix[bot] wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
CVE-2025-25288 in @octokit/plugin-paginate-rest - low severity
@octokit/plugin-paginate-rest is the Octokit plugin to paginate REST API endpoint responses. For versions starting in 1.0.0 and prior to 11.4.1 of the npm package @octokit/plugin-paginate-rest, when calling octokit.paginate.iterator(), a specially crafted octokit instance—particularly with a malicious link parameter in the headers section of the request—can trigger a ReDoS attack. Version 11.4.1 contains a fix for the issue.
Details
Remediation Aikido suggests bumping this package to version 9.2.2 to resolve this issue
Reply @AikidoSec ignore: [REASON] to ignore this issue.
More info
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade dependencies to fix critical SSRF/proxy bypass vulnerabilities in Axios, HTTP Parameter Pollution in form-data, and RCE risks in other packages. This update includes breaking changes that require manual migration.
Breaking Change: Null-prototype merged objects
Where your code is affected:
dist/index.js(line withdelete this.axios.defaults.headers.post['Content-Type']) - The@slack/web-apipackage accessesthis.axios.defaults.headers.post['Content-Type']directlydist/index.js(multiple locations) - Direct bracket notation access to headers objects:headers['Content-Type'],headers[header]dist/index.js(form data handling) - Loop usingfor (const [header, value] of Object.entries(form.getHeaders()))followed byheaders[header] = valueImpact:
In axios 0.32.0, merged config and header objects now have a null prototype to prevent prototype pollution. The code uses direct property access via bracket notation (e.g.,
headers['Content-Type'],this.axios.defaults.headers.post['Content-Type']) without usingObject.prototype.hasOwnProperty.call(). While bracket notation access still works, any implicit string coercion or prototype method calls on these objects will fail since they no longer inherit from Object.prototype.Remediation:
Update the
@slack/web-apipackage to a version compatible with axios 0.32.0, or ensure all header/config object access usesObject.prototype.hasOwnProperty.call(obj, key)instead of relying on inherited prototype methods. Avoid any implicit string coercion of header or config objects.All breaking changes by upgrading axios from version 0.19.2 to 0.32.0 (CHANGELOG)
Content-Typerequest header when passing FormDatatransformRequestandtoFormData✅ 30 CVEs resolved by this upgrade, including 3 critical 🚨 CVEs
This PR will resolve the following CVEs:
allowAbsoluteUrlsnot being set tofalseby default inbuildFullPath(), allowing attackers to bypass URL restrictions and process unintended URLs.formDataToJSONfunction allows attackers to manipulate object properties. Additionally, a ReDoS vulnerability incombineURLscan cause denial of service through malicious input.This issue affects form-data: < 2.5.4, 3.0.0 - 3.0.3, 4.0.0 - 4.0.3.