Improve performance of ObjectSelectionTree#90
Merged
Conversation
Birdy2014
changed the title
pixelsandpointers
approved these changes
Mar 12, 2025
Owner
pixelsandpointers
left a comment
pixelsandpointers
left a comment
There was a problem hiding this comment.
It would not be practical to introduce a variable like: requires_compute_transforms and just compute them once at the end of the method?
Collaborator
Author
In the future, if I continue working on this, having such a flag in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a stupid mistake that causes huge performance loss when a node is dragged and held over the ObjectSelectionTree.
The IDs are now set more efficiently, which makes the performance of the ObjectSelectionTree finally acceptable.