Remove use of protobuf debug APIs in test assertions to fix breaking change#2287
Merged
ddelnano merged 1 commit intopixie-io:mainfrom Dec 8, 2025
Conversation
…change (https://protobuf.dev/news/2024-12-04/) Signed-off-by: Dom Del Nano <ddelnano@gmail.com> (cherry picked from commit 720d2df)
vihangm
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Remove use of protobuf debug APIs in test assertions to fix breaking change
Protobuf v30 and later intentionally malform the
DebugStringstring output to prevent it from being parsed as a protobuf message (announcement details). This breaks our protobuf test assertions and is something we need to fix ahead of migrating to bazel 7.Relevant Issues: #2282
Type of change: /kind cleanup
Test Plan: Build should pass