Replace u8string method to keep return value consistent#2308
Merged
ddelnano merged 1 commit intopixie-io:mainfrom Jan 5, 2026
Merged
Replace u8string method to keep return value consistent#2308ddelnano merged 1 commit intopixie-io:mainfrom
ddelnano merged 1 commit intopixie-io:mainfrom
Conversation
Signed-off-by: Dom Del Nano <ddelnano@gmail.com>
vihangm
approved these changes
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Replace
u8stringmethod to keep return value consistentIn c++ 20, the
u8stringmethod uses a different return type. This PR removes the use of this function to keep the code compatible with c++17 and c++20 in preparation for the clang 21 upgrade.Relevant Issues: #2298
Type of change: /kind cleanup
Test Plan: Build should succeed