Skip to content

Revert back to a working version #538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kuettler wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Revert back to a working version #538

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ed8bcc
Revert "Added letfn"
Jan 2, 2019
498310d
Revert "Add test for the letfn macro"
Jan 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions pixie/stdlib.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -482,19 +482,6 @@
(let [nm (with-meta nm (assoc (meta nm) :private true))]
(cons `defn (cons nm rest))))

(defmacro letfn
"fnspec ==> (fname [params*] exprs) or (fname ([params*] exprs)+)

Takes a vector of function specs and a body, and generates a set of
bindings of functions to their names. All of the names are available
in all of the definitions of the functions, as well as the body."
{:added "0.2"
:forms '[(letfn [fnspecs*] exprs*)]}
[fnspecs & body]
`(letfn* ~(vec (interleave (map first fnspecs)
(map #(cons `fn %) fnspecs)))
~@body))

(defn not
{:doc "Inverts the input, if a truthy value is supplied, returns false, otherwise
returns true."
Expand Down
13 changes: 0 additions & 13 deletions tests/pixie/tests/test-stdlib.pxi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -829,16 +829,3 @@
:b 2
"c" 3
"d" 4}))))))

(t/deftest test-letfn
(letfn [(hello [] "Hello")
(adder [x y] (+ x y))]
(t/assert= "Hello" (hello))
(dotimes [i 10]
(dotimes [j 20]
(t/assert= (+ i j) (adder i j)))))
(letfn [(f [x n] (vec (repeat n x)))]
(t/assert= (f :x 3) [:x :x :x])
(t/assert= (f 0 20) [0 0 0 0 0
0 0 0 0 0
0 0 0 0 0])))