Skip to content

chore: replace @ts-ignore with @ts-expect-error in playground actions#397

Open
CodesWithSubham wants to merge 2 commits into
piyushdotcomm:developfrom
CodesWithSubham:chore/replace-ts-ignore-with-ts-expect-error
Open

chore: replace @ts-ignore with @ts-expect-error in playground actions#397
CodesWithSubham wants to merge 2 commits into
piyushdotcomm:developfrom
CodesWithSubham:chore/replace-ts-ignore-with-ts-expect-error

Conversation

@CodesWithSubham
Copy link
Copy Markdown

@CodesWithSubham CodesWithSubham commented May 29, 2026

Summary

  • replaced the existing @ts-ignore directive with @ts-expect-error in modules/playground/actions/index.ts
  • added a clearer comment explaining the Prisma nested create typing limitation
  • updated the suppression directive to follow TypeScript best practices
  • this change helps TypeScript report unused suppressions if the underlying type issue is resolved in the future

Type of change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Test or CI improvement
  • Starter template change

Related issue

Closes #295

Validation

  • npm run lint
  • npm test
  • npm run build

List any additional manual verification you performed:

  • verified the TypeScript suppression comment still allows the Prisma nested create operation without changing runtime behavior
  • confirmed no functional logic was modified

Screenshots or recordings

Not applicable — this change only updates a TypeScript suppression directive and does not affect the UI.

Checklist

  • I kept this PR focused on one primary change
  • I updated documentation if behavior changed
  • I did not commit secrets, local logs, or scratch files
  • I am requesting review on the correct scope

Summary by CodeRabbit

  • Chores
    • Improved internal TypeScript error handling to tighten code quality and surface expected compile-time issues during development.

Review Change Stack

@qodo-code-review
Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@github-actions
Copy link
Copy Markdown

👋 Thanks for opening a PR, @CodesWithSubham!

Your PR has entered the 🚦 PR Review Pipeline.

Standard PR detected — your PR will follow the standard review pipeline.


What happens next

Stage Reviewer Checks
Stage 1 — Automated Validation 🤖 Bot DCO · Format · AI/Slop · Duplicate
Stage 2 — Human Review 👥 Maintainer Code + Quality Review
Stage 3 — PA / Maintainer Review 🔑 Project Admin Final Merge Decision

A pipeline status comment will appear below and update automatically as your PR progresses.


While you wait

  • Sign all commits (git commit -s)
  • Link your issue (Closes #123)
  • Use a feature branch (not main)
  • Avoid unrelated changes

This comment is posted only once.

@github-actions github-actions Bot added level:beginner Beginner level task for GSSoC mentor:piyushdotcomm labels May 29, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: eb79dfcb-b6ba-42da-995b-5d7bffa44576

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Walkthrough

Changed the TypeScript suppression directive in modules/playground/actions/index.ts (line 249) from @ts-ignore to @ts-expect-error above the Prisma nested create mapping used in duplicateProjectById.

Changes

TypeScript Error Suppression Best Practice

Layer / File(s) Summary
Type suppression directive upgrade
modules/playground/actions/index.ts
Line 249: Replaced @ts-ignore with @ts-expect-error above the Prisma nested create mapping for templateFiles in duplicateProjectById.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

type:refactor

Suggested reviewers

  • piyushdotcomm

Poem

I nibble on code with gentle cheer,
Swapped ignore for a stricter ear,
Now errors must show to pass the test,
So future fixes won't be guessed,
A rabbit's hop toward tidy code 🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: replacing @ts-ignore with @ts-expect-error in the playground actions file.
Description check ✅ Passed The description follows the template structure, clearly explains the changes, validates all checks, and documents the rationale for the upgrade.
Linked Issues check ✅ Passed The PR directly addresses issue #295 by replacing @ts-ignore with @ts-expect-error in modules/playground/actions/index.ts as required.
Out of Scope Changes check ✅ Passed All changes are within scope; the PR modifies only the TypeScript suppression directive as specified in issue #295.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Replace the existing `@ts-ignore` directive in Playground Actions
with `@ts-expect-error` to follow TypeScript best practices.

This ensures the compiler will report an error if the ignored
TypeScript issue is resolved in the future, preventing unnecessary
suppression comments from remaining in the codebase.

Changes:
- replaced `@ts-ignore` with `@ts-expect-error`
- kept existing runtime behavior unchanged
- no functional logic modified

Signed-off-by: Subham Duary <subhamduary11@gmail.com>
@CodesWithSubham CodesWithSubham force-pushed the chore/replace-ts-ignore-with-ts-expect-error branch from 12c3827 to 800b10d Compare May 29, 2026 20:41
@piyushdotcomm piyushdotcomm changed the base branch from main to develop June 1, 2026 15:32
Copy link
Copy Markdown
Owner

@piyushdotcomm piyushdotcomm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Maintenance: Upgrade @ts-ignore to @ts-expect-error in Playground Actions

2 participants