Merged
Conversation
aerc bakes its share and libexec directories into the binary at compile time via Go ldflags. Without explicit overrides, these resolve to the build machine's absolute prefix (including the +brewing suffix), which won't exist on other users' machines or even locally after pkgx moves the build to its final path. Fix by setting SHAREDIR and LIBEXECDIR to ~/.pkgx/aerc-mail.org/v<ver>/ paths with a literal tilde. aerc's xdg.ExpandHome() expands ~ to the current user's home directory at runtime, so the binary correctly locates its config files on any machine.
Contributor
Author
|
so this latest commit "works" but i'm not sure about the best pattern for fixing issues like this where the prefix is baked into the binary. |
Updated Go version dependency and modified build script to use MAKE_ARGS for installation.
Contributor
|
thanks, @scottjg . cleaned up the syntax a little, but it looks good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AI Intent
Risk Assessment
Rollback Plan
Validation
Internal/Public Boundary Check
added.