fix: eliminate data race in test helper and enforce race gate in CI#53
Open
pkkummermo wants to merge 2 commits into
Open
fix: eliminate data race in test helper and enforce race gate in CI#53pkkummermo wants to merge 2 commits into
pkkummermo wants to merge 2 commits into
Conversation
- Remove shared err variable written across goroutines in HTTPTestUtil (start goroutine and shutdown caller both wrote to the same err) - Increase generalStartupTimeoutInMS from 1ms to 50ms to prevent flaky startup-timeout failures under race instrumentation - Add pull_request trigger and Go 1.24.x/1.25.x matrix to unit-test job - Add dedicated race-test job running go test -race on Go 1.25.x only - Align CI Go version and action versions to current baseline (1.25.x, actions/checkout@v4, actions/setup-go@v5) - Add CONTEXT.md capturing agreed domain language and quality policies
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…ntain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errvariable written across goroutines inHTTPTestUtil(start goroutine and shutdown caller both wrote to the sameerr)generalStartupTimeoutInMSfrom 1ms to 50ms to prevent flaky startup-timeout failures under race instrumentationpull_requesttrigger and Go 1.24.x/1.25.x matrix to unit-test jobrace-testjob runninggo test -raceon Go 1.25.x onlyVerification
go test ./...passesgo test -race ./...passes