Skip to content

[76] Fix typed parameters and multi-space properties in animation profile parser#77

Merged
nirlipo merged 2 commits into
developfrom
76-types-and-width-support
Jun 10, 2026
Merged

[76] Fix typed parameters and multi-space properties in animation profile parser#77
nirlipo merged 2 commits into
developfrom
76-types-and-width-support

Conversation

@nirlipo

@nirlipo nirlipo commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Typed parameters: PDDL predicates with typed parameters (e.g. (?r - robot ?l - location)) caused a logic error because :parameters was split verbatim, including - and type names. Now filters to tokens starting with ? so only parameter names are kept; untyped profiles are unaffected.
  • Multi-space properties: The properties regex \s matched exactly one space, so entries written with extra whitespace (e.g. (width 36)) were silently dropped from the visual block and never reached objects_dic. Changed to \s+ to allow one or more spaces, and + instead of * for the value group to require a non-empty value.

Test plan

  • Animation profile with typed parameters (e.g. (?r - robot ?l - location)) parses correctly — only ?r, ?l in objectList
  • Visual properties with multiple spaces (e.g. (width 36)) appear in animation_profile["visual"] and propagate to stageitems
  • Existing untyped animation profiles and single-space properties continue to work unchanged

Resolves #76

🤖 Generated with Claude Code

nirlipo added 2 commits June 10, 2026 14:59
PDDL typed parameters (e.g. (?r - robot ?l - location)) caused a logic
error because the :parameters block was split verbatim, including '-'
and type names. Now filters to tokens starting with '?' so only the
parameter names are kept; untyped profiles are unaffected.

Resolves #76
The regex \s matched exactly one space, so properties written with
extra whitespace (e.g. "(width  36)") were silently dropped from the
visual block. Changed to \s+ to allow one or more spaces, and +
instead of * for the value group to require a non-empty value.

Resolves #76
@nirlipo nirlipo merged commit 94d82af into develop Jun 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for typed parameters and width property in animation profiles

1 participant