Conversation
|
Hi @erwinvaneyk , @pshanbhag I don't have write access to the repo and therefore cannot ask for review and / or resolve merge conflicts, it seems. This PR is in draft state since I see a message that "This branch has conflicts that must be resolved". |
|
This branch has conflicts that must be resolved :-/ |
Code Review Agent Run Status
|
14 similar comments
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
Code Review Agent Run Status
|
…#4524) Bumps [github.com/mattn/go-sqlite3](https://github.com/mattn/go-sqlite3) from 1.14.33 to 1.14.34. - [Release notes](https://github.com/mattn/go-sqlite3/releases) - [Commits](mattn/go-sqlite3@v1.14.33...v1.14.34) --- updated-dependencies: - dependency-name: github.com/mattn/go-sqlite3 dependency-version: 1.14.34 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/lib/pq](https://github.com/lib/pq) from 1.11.1 to 1.11.2. - [Release notes](https://github.com/lib/pq/releases) - [Changelog](https://github.com/lib/pq/blob/master/CHANGELOG.md) - [Commits](lib/pq@v1.11.1...v1.11.2) --- updated-dependencies: - dependency-name: github.com/lib/pq dependency-version: 1.11.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.78.0 to 1.79.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.78.0...v1.79.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.79.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.78.0 to 1.79.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.78.0...v1.79.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.79.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [docker/build-push-action](https://github.com/docker/build-push-action) from 6.19.1 to 6.19.2. - [Release notes](https://github.com/docker/build-push-action/releases) - [Commits](docker/build-push-action@601a80b...10e90e3) --- updated-dependencies: - dependency-name: docker/build-push-action dependency-version: 6.19.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) Bumps [aquasecurity/trivy-action](https://github.com/aquasecurity/trivy-action) from 0.33.1 to 0.34.0. - [Release notes](https://github.com/aquasecurity/trivy-action/releases) - [Commits](aquasecurity/trivy-action@b6643a2...c1824fd) --- updated-dependencies: - dependency-name: aquasecurity/trivy-action dependency-version: 0.34.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: maksim.nabokikh <max.nabokih@gmail.com>
Signed-off-by: Logan <31484824+loganripplinger@users.noreply.github.com>
Signed-off-by: maksim.nabokikh <max.nabokih@gmail.com>
…ipt (#4542) Signed-off-by: maksim.nabokikh <max.nabokih@gmail.com>
Signed-off-by: maksim.nabokikh <max.nabokih@gmail.com>
Signed-off-by: Maksim Nabokikh <maksim.nabokikh@flant.com>
| on: | ||
| branch_protection_rule: | ||
| push: | ||
| branches: [ main ] |
There was a problem hiding this comment.
Scorecard workflow targets main instead of master
Low Severity
The new analysis-scorecard.yaml workflow triggers on pushes to branches: [ main ], but this fork's default branch is master (as seen in ci.yaml). The scorecard push trigger will never fire. The workflow only runs on the weekly schedule and branch_protection_rule events, which may not be the intent.
…0f` (#4546) Bumps distroless/static-debian13 from `f9f84bd` to `01e550f`. --- updated-dependencies: - dependency-name: distroless/static-debian13 dependency-version: nonroot dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.79.0 to 1.79.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.79.0...v1.79.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.79.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.79.0 to 1.79.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.79.0...v1.79.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.79.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the etcd group with 2 updates: [go.etcd.io/etcd/client/pkg/v3](https://github.com/etcd-io/etcd) and [go.etcd.io/etcd/client/v3](https://github.com/etcd-io/etcd). Updates `go.etcd.io/etcd/client/pkg/v3` from 3.6.7 to 3.6.8 - [Release notes](https://github.com/etcd-io/etcd/releases) - [Commits](etcd-io/etcd@v3.6.7...v3.6.8) Updates `go.etcd.io/etcd/client/v3` from 3.6.7 to 3.6.8 - [Release notes](https://github.com/etcd-io/etcd/releases) - [Commits](etcd-io/etcd@v3.6.7...v3.6.8) --- updated-dependencies: - dependency-name: go.etcd.io/etcd/client/pkg/v3 dependency-version: 3.6.8 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: etcd - dependency-name: go.etcd.io/etcd/client/v3 dependency-version: 3.6.8 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: etcd ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 4.32.2 to 4.32.3. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@45cbd0c...9e907b5) --- updated-dependencies: - dependency-name: github/codeql-action dependency-version: 4.32.3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Maksim Nabokikh <maksim.nabokikh@flant.com>
Added steps to fetch and extract OCI image tarball. Signed-off-by: Maksim Nabokikh <maksim.nabokikh@flant.com>
| outputs: | ||
| name: ${{ steps.image-name.outputs.value }} | ||
| digest: ${{ steps.build.outputs.digest }} | ||
| ref: ${{ steps.image-ref.outputs.value }} |
There was a problem hiding this comment.
Matrix job outputs are non-deterministic across variants
Medium Severity
The container-images job uses a matrix strategy with alpine and distroless variants but defines job-level outputs for digest and ref. GitHub Actions picks outputs from a single arbitrary matrix leg, so the exposed workflow outputs (container-image-digest, container-image-ref) will non-deterministically correspond to either variant. These outputs are part of the workflow_call API contract and could silently produce wrong values for any consumer.
…estamp (#4553) Signed-off-by: maksim.nabokikh <max.nabokih@gmail.com>
Signed-off-by: maksim.nabokikh <max.nabokih@gmail.com>
Bumps [helm/kind-action](https://github.com/helm/kind-action) from 1.13.0 to 1.14.0. - [Release notes](https://github.com/helm/kind-action/releases) - [Commits](helm/kind-action@92086f6...ef37e7f) --- updated-dependencies: - dependency-name: helm/kind-action dependency-version: 1.14.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [google.golang.org/api](https://github.com/googleapis/google-api-go-client) from 0.266.0 to 0.267.0. - [Release notes](https://github.com/googleapis/google-api-go-client/releases) - [Changelog](https://github.com/googleapis/google-api-go-client/blob/main/CHANGES.md) - [Commits](googleapis/google-api-go-client@v0.266.0...v0.267.0) --- updated-dependencies: - dependency-name: google.golang.org/api dependency-version: 0.267.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: maksim.nabokikh <max.nabokih@gmail.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| uses: actions/cache/save@cdf6c1fa76f9f475f3d7449005a359c84ca0f306 # v5.0.3 | ||
| with: | ||
| path: ${{ github.workspace }}/.cache/trivy | ||
| key: cache-trivy-${{ steps.date.outputs.date }} |
There was a problem hiding this comment.
Trivy cache key prefix mismatch between workflows
Medium Severity
The daily Trivy DB cache workflow saves with key prefix cache-trivy- while the artifacts workflow restores with prefix trivy-cache-. These prefixes are swapped, so the restore-keys: trivy-cache- pattern will never match cache-trivy-* keys. Since the artifacts workflow also sets TRIVY_SKIP_DB_UPDATE: true, the Trivy scan relies entirely on a cached database. On first run or after cache expiry, no database is available and the scan will fail or produce empty results. The cache paths also differ (${{ github.workspace }}/.cache/trivy vs cache/db).


Overview
Sync the pf9 fork with dexidp/dex master to bring in all the changes from https://github.com/dexidp/dex/releases/tag/v2.35.3 + this PR dexidp#2708 from master
What this PR does / why we need it
Bring in the upstream fixes to improve security (there is a known CVE), bring in fixes / optimisations
ArgoCD has now released patches for v2.2 and v2.4 that fix this in ArgoCD's dex server pod (by upgrading to v2.25.3 of upstream dex).
We are missing this (just upgrading ArgoCD will not help) since we use our own forked dex
Special notes for your reviewer
Does this PR introduce a user-facing change?
Note
Medium Risk
Touches CI/release pipelines and container build/signing paths; misconfiguration could break publishing, provenance, or image runtime expectations despite limited application logic changes.
Overview
CI and release automation is revamped: introduces reusable
artifacts.yaml(called fromci.yamland newrelease.yaml) that builds multi-arch images (addss390x), optionally pushes on release/tag, signs withcosign, creates provenance attestations, and runs Trivy scans with caching + SARIF uploads; adds OpenSSF Scorecard and a scheduled Trivy DB cache workflow, and removes legacydocker.yaml/codeql-analysis.yaml.Build/tooling inputs are updated: Docker build now uses
tonistiigi/xx+ newer Go/Alpine/distroless bases, ensures a nonrootdexuser exists in images, bumps gomplate, and threadsVERSIONinto builds; Makefile is reorganized with explicitgenerate/verifytargets, updated tool versions (protoc/kind/golangci-lint), and addsgo mod tidyacross modules.Repo hygiene/docs updates: dependabot now includes
/examplesand groups etcd deps;.golangci.ymlis replaced with.golangci.yaml; PR/issue/security templates and README/ADOPTERS links/text are refreshed; protobuf-generated Go files are regenerated with newerprotoc/plugins (no API shape change, but new generated code layout).Written by Cursor Bugbot for commit 29c7b6f. This will update automatically on new commits. Configure here.