Open
Conversation
mithilarun
approved these changes
Jan 11, 2022
mithilarun
left a comment
mithilarun
left a comment
There was a problem hiding this comment.
These changes look good. Could you add similar code to the DownloadFile function below too?
Contributor
|
@xagent003 , just wanted to know if this change should be part of the upcoming pf9ctl release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying new change for creating Comms registry.json file, it works on upgrade. But failing on new DU with fresh hosts. The /etc/pf9/comms/ dir does not exist. So UploadFile is failing. Might need changes in pf9ctl to have the sftpClient do a MkdirAll on the filepath's dir, before it does the remote .Create: