unattended-upgrades disable issue

[devidask27]

ISSUE(S):

https://platform9.atlassian.net/browse/FT-388

SUMMARY

Before running the installer script we are disabling the unattended-upgrades so that there should not be any problem while installing hostagent, but one of the user git dpkg lock error while installing hostagent.

ISSUE TYPE

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that may cause existing functionality to not work as expected)
• This change requires a documentation update

IMPACTED FEATURES/COMPONENTS:

prep-node

TESTING DONE

Manual

if user already have disabled unattended-upgrades

if unattended-upgrades are enabled

Reviewers

/cc @pshanbhag @anmolsachan

[pshanbhag]

@devidask27 - I am not for such a change. It is too intrusive and I don't think we are restoring the file back to the original settings.
Is there value in this check? I would like to discuss with anyone who is pushing for this check. One option is to detect unattended upgrade is running and share the message with the user.

[devidask27]

@devidask27 - I am not for such a change. It is too intrusive and I don't think we are restoring the file back to the original settings. Is there value in this check? I would like to discuss with anyone who is pushing for this check. One option is to detect unattended upgrade is running and share the message with the user.

The issue is hostagent installation failed because of dpkg was acquired by unattended upgrades. we have check for dpkg lock check. it checks if dpkg lock is acquired by any other process. if it is acquired then it error out. but here the case is hostagent installation is failing if unattended upgrade or any other process acquires dpkg lock after our dpkg check or while hostagent is being installed.