bake virtio 0.1.185 for windows server 2012#1425
Merged
meghansh-pf9 merged 22 commits intomainfrom Feb 25, 2026
Merged
Conversation
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
OmkarDeshpande7
force-pushed
the
private/main/omkard/bake-virtio-0.1.189
branch
2 times, most recently
from
6f537b3 to
82466ac
Compare
OmkarDeshpande7
force-pushed
the
private/main/omkard/bake-virtio-0.1.189
branch
2 times, most recently
from
4d7f0f0 to
62b71b0
Compare
OmkarDeshpande7
changed the title
meghansh-pf9
force-pushed
the
private/main/omkard/bake-virtio-0.1.189
branch
3 times, most recently
from
5d64a21 to
c967619
Compare
meghansh-pf9
force-pushed
the
private/main/omkard/bake-virtio-0.1.189
branch
from
fb70354 to
30c8f8d
Compare
Signed-off-by: Meghansh Tyagi <meghansh@platform9.com>
meghansh-pf9
force-pushed
the
private/main/omkard/bake-virtio-0.1.189
branch
from
df466c3 to
15bbcf0
Compare
meghansh-pf9
force-pushed
the
private/main/omkard/bake-virtio-0.1.189
branch
from
15bbcf0 to
6d79041
Compare
Signed-off-by: Meghansh Tyagi <meghansh@platform9.com>
spai-p9
reviewed
Feb 24, 2026
Collaborator
spai-p9
left a comment
spai-p9
left a comment
There was a problem hiding this comment.
Check this, rest looks good
|
|
||
| // Use Windows Server 2012-specific ISO if detected | ||
| if strings.Contains(strings.ToLower(osRelease), "server 2012") || strings.Contains(strings.ToLower(osRelease), "server2012") { | ||
| filePath = "/home/fedora/virtio-win/virtio-win-server12.iso" |
Collaborator
There was a problem hiding this comment.
Adding this should be enough right? do we again need to run the fireboat install script install-virtio-win12.ps1 script? won't virtv2v do this automatically?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
This PR pre-bakes specific virtio version (0.1.189) to VJB VM. Now during migration v2v-helper determines the OS release and version and switches to this virtio-win version in case of windows server 2012. Added the installation script to the scheduler.
Which issue(s) this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged)fixes #1409
Testing done