Skip to content

Validation relies on assert, which is stripped in optimized Python mode #5404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
huyhoang171106 wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −1
Open

Validation relies on assert, which is stripped in optimized Python mode #5404

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion platformio/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@


def projects_dir_validate(projects_dir):
assert os.path.isdir(projects_dir)
if not os.path.isdir(projects_dir):
raise ValueError(projects_dir)
Copy link

Copilot AI Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a regression test for this validator that runs under Python optimized mode (-O) to ensure config validation still rejects a non-existent projects_dir when asserts are stripped (e.g., spawn a subprocess with sys.executable and -O and assert it exits with InvalidSettingValue). This prevents future refactors from reintroducing assert-based validation.

Suggested change
raise ValueError(projects_dir)
raise exception.InvalidSettingValue(
"Invalid 'projects_dir' path: %r" % (projects_dir,)
)

Copilot uses AI. Check for mistakes.
return os.path.abspath(projects_dir)


Expand Down
Loading