[wip] Feat preview custom props on goals #5977
Draft
+2,606
−115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aerosol
force-pushed
the
feat-preview-custom-props-on-goals
branch
from
90d802d to
e861beb
Compare
|
aerosol
force-pushed
the
feat-preview-custom-props-on-goals
branch
from
0f70963 to
79098c7
Compare
…pair - Add input and dropdown class attributes to combobox. - Adjust combobox dropdown within a property pair to overflow to max the width of the property pair container, with help of container-type:inline-size. - Ensure trash icon wrapper is hidden when icon is hidden. - Add title attribute to option when it is being truncated.
- Improve `Upgrade` CTA in list and turn it into a link - Improve `Upgrade` CTA tooltip copy to make it more clear what happens with locked goals on the dashboard - Add disabled (faded) styling to icon button and toggle switch - Move disabled styling to toggle only in goal form - Add `link_class` attribute to `upgrade_call_to_action` component in order to override link color when displayed inside tooltip - Add `Business` pill to goal form to make it more obvious that the feature is locked, and make it a link to the billing page - Improve prop styling inside tooltip in goal list to make it more readable and ensure truncation when prop is long
sanne-san
force-pushed
the
feat-preview-custom-props-on-goals
branch
from
3398dd5 to
0daac2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Please describe the changes made in the pull request here.
Below you'll find a checklist. For each item on the list, check one option and delete the other.
Tests
Changelog
Documentation
Dark mode