Liveview dashboard datepicker #6000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoldar
approved these changes
Jan 14, 2026
| phx-value-goal-type="scroll" | ||
| x-data | ||
| x-on:click={Modal.JS.preopen("goals-form-modal")} | ||
| :for={ |
|
Hey 👋 - I ran this through Ito.ai to test and it flagged a potential issue: ❌️ 1 potential issue flagged — 17 test cases ran
We found it by pulling down the PR, running it in a local environment, and thoroughly testing against it. There may be minor issues because we didn't have a perfect data to seed the environment. I see that the change was already merged so it may have been a visual library issue. Test screenshot 16 other passed testcases:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note: this PR targets the
liveview-dashboardPOC branch, not master.Adds optimistic datepicker label updates as well as arrows for prev/next period navigation. The arrows currently need to be clicked. Keyboard shortcuts are out of scope. The logic is built up as follows:
relative_date(or today by default) in both directions by 10 units (either day, month, or year). Any future dates are cut off bytoday(site.timezone). Also, currently out of scope, but we should also cut off any dates that fall beforesite.stats_start_date.relative_datealso belongs to this array. Its index is passed as adata-*attribute as well.