Skip to content

Pass args instead of rest to dropdown_item as function #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RobertJoonas wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Pass args instead of rest to dropdown_item as function #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc5cae1
args instead of rest
RobertJoonas Jan 12, 2026
b86c7ba
Empty test commit
zoldar Jan 12, 2026
9ca6d97
add built asset
RobertJoonas Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ erl_crash.dump
prima-*.tar

# Ignore assets that are produced by build tools.
/priv/static/assets/
# /priv/static/assets/
/demo/priv/static/assets/

# Ignore digested assets cache.
Expand Down
6 changes: 2 additions & 4 deletions lib/prima/dropdown.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,10 +130,7 @@ defmodule Prima.Dropdown do
attr :class, :string, default: ""
attr :disabled, :boolean, default: false
attr :as, :any, default: nil

# Workaround - unfortunately there seems to be no way to pass through arbitrary assigns without emitting compile warnings
# Since dropdown items are often rendered as links, we add the <.link> attributes here as well.
attr :rest, :global, include: ~w(navigate patch href)
attr :args, :map, default: %{}
slot :inner_block, required: true

@doc """
Expand All @@ -149,6 +146,7 @@ defmodule Prima.Dropdown do
* `class` - CSS classes for styling the menu item
* `disabled` - Boolean to mark the item as disabled (default: false)
* `as` - Custom function component to render instead of the default div element
* `args` - A map of args passed directly to the `as` function

## Examples

Expand Down
Loading
Loading