Fix common db relation insertion

[Lainow]

Checklist before requesting a review

Please delete options that are not relevant.

• I have performed a self-review of my code.
• I have added tests (when available) that prove my fix is effective or that my feature works.
• This change requires a documentation update.

Description

• It fixes !35251
• Here is a brief description of what this PR does
  Fixed an error when inserting data linked to a relationship table (for example, the supplier identifier was removed from the list because the type was relationship).

Screenshots (if appropriate):

[Rom1-B]

It looks OK, can you get the customer to validate it?

[stonebuzz]

I'm not sure about the fix, with this example (inject groups_id from User object)

User -> groups_id (from Group_User)

The condition will return false (to delegate to specific case) -> OK

But with this

User -> name

The condition will return false -> KO

Because User is not an instance of CommonDBRelation

Suggested change

	if ($option !== false && isset($option['displaytype']) && $option['displaytype'] == 'relation' && !($item instanceof CommonDBRelation)) {
	if (($option !== false && isset($option['displaytype']) && $option['displaytype'] == 'relation') || !($item instanceof CommonDBRelation)) {

[Lainow]

With the || operator, the plugin doesn't insert any data, whereas with &&, all data is actually inserted.

[Lainow]

And I tested with a user like you said but everything works perfectly.

[stonebuzz]

👍

[stonebuzz]

It looks OK, can you get the customer to validate it?

[stonebuzz]

Reminder (adapt CHANGELOG.md)

[stonebuzz]

can you rebase (customer is OK with this change?)

[Lainow]

can you rebase (customer is OK with this change?)

I'm waiting for their reply

[Lainow]

That's good