-
Notifications
You must be signed in to change notification settings - Fork 21
Fix multiple small issues #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix multiple small issues #45
Conversation
|
I have no rights on this repo so I can't request reviews or merge. Ping @trasher and @cedric-anne for review/merge ;) |
|
Or even @Rom1-B, I guess plugins are your responsibility so no need to bother R&D :) |
|
@AdrienClairembault I added you to the team; you should have rights now. |
Thanks! |
|
I've also noticed that the correct header is not applied to the two php files, I'll fix it too. |
|
What do you think about also adding the default configuration for our whole CI suite (PHPunit, PHP-CS-Fixer, Rector, Psalm, PHPstan)? |
Yes, but be careful, because you often have to list the folder to be scanned, so you should probably make a note about this. |
|
I'll keep this in draft for now as I keep finding things to fix. |
Or create defaut directories with a .gitkeep file and/or comment the linters config files entries that corresponds to optional directories that should be created by default. |
19b5a45 to
54660e2
Compare
|
I merged it manually in #44. |
I'm creating a new plugin for GLPI 11 and noticed a few issues: