Skip to content

Conversation

@AdrienClairembault
Copy link
Contributor

I'm creating a new plugin for GLPI 11 and noticed a few issues:

  • PHP version requirements are not consistent with the one from GLPI's 11 composer file
  • There are a few spelling mistakes
  • License file is MIT but plugin xml says the license is GPL
  • The sed commands were missing one occurrence of $LNAME because it is used twice on one line and sed only replace the first one by default image

@AdrienClairembault
Copy link
Contributor Author

I have no rights on this repo so I can't request reviews or merge.

Ping @trasher and @cedric-anne for review/merge ;)

@AdrienClairembault
Copy link
Contributor Author

Or even @Rom1-B, I guess plugins are your responsibility so no need to bother R&D :)

@trasher trasher requested review from Rom1-B and cedric-anne August 14, 2025 13:26
@trasher
Copy link
Contributor

trasher commented Aug 14, 2025

@AdrienClairembault I added you to the team; you should have rights now.

@AdrienClairembault
Copy link
Contributor Author

@AdrienClairembault I added you to the team; you should have rights now.

Thanks!

@AdrienClairembault
Copy link
Contributor Author

I've also noticed that the correct header is not applied to the two php files, I'll fix it too.

@AdrienClairembault
Copy link
Contributor Author

What do you think about also adding the default configuration for our whole CI suite (PHPunit, PHP-CS-Fixer, Rector, Psalm, PHPstan)?

@Rom1-B
Copy link
Contributor

Rom1-B commented Aug 14, 2025

What do you think about also adding the default configuration for our whole CI suite (PHPunit, PHP-CS-Fixer, Rector, Psalm, PHPstan)?

Yes, but be careful, because you often have to list the folder to be scanned, so you should probably make a note about this.

@AdrienClairembault
Copy link
Contributor Author

I'll keep this in draft for now as I keep finding things to fix.

@cedric-anne
Copy link
Contributor

What do you think about also adding the default configuration for our whole CI suite (PHPunit, PHP-CS-Fixer, Rector, Psalm, PHPstan)?

Yes, but be careful, because you often have to list the folder to be scanned, so you should probably make a note about this.

Or create defaut directories with a .gitkeep file and/or comment the linters config files entries that corresponds to optional directories that should be created by default.

@cedric-anne cedric-anne force-pushed the feature/glpi-11.0 branch 2 times, most recently from 19b5a45 to 54660e2 Compare August 20, 2025 11:57
@cedric-anne
Copy link
Contributor

I merged it manually in #44.

@AdrienClairembault AdrienClairembault deleted the fix-misc branch August 20, 2025 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants