Skip to content

prevent non existing key "bypass_filter_assign_group" in ticket.class… #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CorentinS6 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

prevent non existing key "bypass_filter_assign_group" in ticket.class… #401

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inc/ticket.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1264,7 +1264,7 @@ public function showForm($ID, $options = [])
$condition = [
'is_assign' => 1,
];
if ($config->fields['use_filter_assign_group'] && !$user_config->fields['bypass_filter_assign_group']) {
if ($config->fields['use_filter_assign_group'] && isset($user_config->fields['bypass_filter_assign_group']) && !$user_config->fields['bypass_filter_assign_group']) {
Copy link
Contributor

@stonebuzz stonebuzz Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ($config->fields['use_filter_assign_group'] && isset($user_config->fields['bypass_filter_assign_group']) && !$user_config->fields['bypass_filter_assign_group']) {
if ($config->fields['use_filter_assign_group'] && (!isset($user_config->fields['bypass_filter_assign_group']) || !$user_config->fields['bypass_filter_assign_group'])) {

Copy link
Contributor

@Rom1-B Rom1-B Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if ($config->fields['use_filter_assign_group'] && isset($user_config->fields['bypass_filter_assign_group']) && !$user_config->fields['bypass_filter_assign_group']) {
if ($config->fields['use_filter_assign_group'] ?? false && !($user_config->fields['bypass_filter_assign_group'] ?? false)) {

Copy link
Contributor

@stonebuzz stonebuzz Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use / test the second proposal and let me know if it works for you.

$condition['id'] = $groups_id_filtered;
}
TemplateRenderer::getInstance()->display('@escalade/escalade_form.html.twig', [
Expand Down