Skip to content

Fix(Reporting): Fix LIMIT clause #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rom1-B merged 3 commits into from
Dec 24, 2025
Merged

Fix(Reporting): Fix LIMIT clause #332

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
84ab806
Fix(Reporting): Fix LIMIT clause
stonebuzz Dec 19, 2025
b18f9bb
Apply suggestions from code review
Rom1-B Dec 24, 2025
69b2b5b
Merge branch 'main' into fix_lilmit_glpi11
Rom1-B Dec 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).

- Fix SQL alias errors for reportVstackbarLifetime chart
- Fix empty `WHERE` clause
- Fix `limit` clause

## [1.9.2] - 2025-12-02

Expand Down
4 changes: 2 additions & 2 deletions inc/helpdeskplus.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,7 +664,7 @@ public function reportHbarTopcategory($config = [])

//Init delay value
$delay = PluginMreportingCommon::getCriteriaDate('glpi_tickets.date', $config['delay'], $config['randname']);
$limit = isset($_SESSION['mreporting_values']['glpilist_limit']) ? '0, ' . $_SESSION['mreporting_values']['glpilist_limit'] : '0, 20';
$limit = isset($_SESSION['mreporting_values']['glpilist_limit']) ? $_SESSION['mreporting_values']['glpilist_limit'] : 20;

$query = [
"SELECT" => [
Expand Down Expand Up @@ -718,7 +718,7 @@ public function reportHbarTopapplicant($config = [])

//Init delay value
$delay = PluginMreportingCommon::getCriteriaDate('glpi_tickets.date', $config['delay'], $config['randname']);
$limit = isset($_SESSION['mreporting_values']['glpilist_limit']) ? '0, ' . $_SESSION['mreporting_values']['glpilist_limit'] : '0, 20';
$limit = isset($_SESSION['mreporting_values']['glpilist_limit']) ? $_SESSION['mreporting_values']['glpilist_limit'] : 20;

$query = [
"SELECT" => [
Expand Down
Loading