-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Accounts page — create, edit, delete accounts with PluresDB #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
09a45bf
Initial plan
Copilot a6c04a3
feat: Accounts page — create, edit, delete accounts with PluresDB
Copilot 7695726
Update plugins/financial-advisor/src/pages/Accounts.svelte
kayodebristol 9bdd8c2
Update plugins/financial-advisor/src/pages/Accounts.svelte
kayodebristol 0ceb8e5
Update plugins/financial-advisor/src/lib/context.ts
kayodebristol f19f265
fix: use showModal() for dialogs, clear context on deactivate
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| /** | ||
| * Account types and helpers for the fa-accounts PluresDB collection. | ||
| */ | ||
|
|
||
| export type AccountType = 'checking' | 'savings' | 'credit' | 'investment'; | ||
|
|
||
| export interface Account { | ||
| id: string; | ||
| name: string; | ||
| institution: string; | ||
| type: AccountType; | ||
| balance: number; | ||
| createdAt: string; | ||
| updatedAt: string; | ||
| } | ||
|
|
||
| export const FA_ACCOUNTS_COLLECTION = 'fa-accounts'; | ||
|
|
||
| export function generateAccountId(): string { | ||
| return `acct-${crypto.randomUUID()}`; | ||
| } | ||
|
|
||
| export const ACCOUNT_TYPE_LABELS: Record<AccountType, string> = { | ||
| checking: 'Checking', | ||
| savings: 'Savings', | ||
| credit: 'Credit Card', | ||
| investment: 'Investment', | ||
| }; | ||
|
|
||
| export const ACCOUNT_TYPE_ICONS: Record<AccountType, string> = { | ||
| checking: '🏦', | ||
| savings: '💰', | ||
| credit: '💳', | ||
| investment: '📈', | ||
| }; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| /** | ||
| * Plugin context singleton for financial-advisor. | ||
| * | ||
| * `setPluginContext` is called from `onActivate` so that Svelte page | ||
| * components can retrieve the PluresDB data API, notify API, etc. | ||
| * without needing Svelte's own `setContext` / `getContext` mechanism | ||
| * (which is scoped to component trees and unavailable in lifecycle hooks). | ||
| */ | ||
|
|
||
| import type { PluginContext } from '@plures/pares-radix'; | ||
|
|
||
| let _context: PluginContext | null = null; | ||
|
|
||
| export function setPluginContext(ctx: PluginContext): void { | ||
| _context = ctx; | ||
| } | ||
|
|
||
|
kayodebristol marked this conversation as resolved.
|
||
| export function clearPluginContext(): void { | ||
| _context = null; | ||
| } | ||
|
|
||
| export function getPluginContext(): PluginContext | null { | ||
| return _context; | ||
| } | ||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onActivatestores the plugin context globally, butonDeactivatedoes not clear it. This can leave a stalePluginContextreachable from pages after the plugin is deactivated. Consider clearing the singleton inonDeactivate(after adding a clear/reset helper inlib/context.ts).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was already applied in f19f265 —
onDeactivatenow callsclearPluginContext(), andclearPluginContextwas added tolib/context.tsin the same commit.