This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Add syscall arguments to clone hooks#102
Open
alberto-miranda wants to merge 1 commit intopmem:masterfrom
Open
Conversation
krzycz
reviewed
Apr 11, 2020
Contributor
krzycz
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @alberto-miranda)
test/test_clone_thread_preload.c, line 99 at r1 (raw file):
*/ static void hook_child(unsigned long clone_flags,
What about parent hook? Would be nice to have it tested as well.
Codecov Report
@@ Coverage Diff @@
## master #102 +/- ##
=======================================
Coverage 91.95% 91.96%
=======================================
Files 11 11
Lines 957 958 +1
=======================================
+ Hits 880 881 +1
Misses 77 77
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the missing arguments to the
clone()system call, so that their values can be inspected when interception hooks are called. In our case, this is useful to keep track of what arguments have been passed to theclone()system call and react accordingly.This change is