This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Add intercept hook after kernel syscall completes#103
Open
alberto-miranda wants to merge 1 commit intopmem:masterfrom
Open
Add intercept hook after kernel syscall completes#103alberto-miranda wants to merge 1 commit intopmem:masterfrom
alberto-miranda wants to merge 1 commit intopmem:masterfrom
Conversation
Author
|
This PR doesn't include a specific test for the new hook since I was unsure what the best way to test it was. I'm open to suggestions :) |
krzycz
reviewed
Apr 11, 2020
Contributor
krzycz
left a comment
krzycz
left a comment
There was a problem hiding this comment.
Could you elaborate on your concerns about the test?
Reviewed 2 of 2 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Codecov Report
@@ Coverage Diff @@
## master #103 +/- ##
==========================================
- Coverage 91.95% 91.86% -0.09%
==========================================
Files 11 11
Lines 957 959 +2
==========================================
+ Hits 880 881 +1
- Misses 77 78 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an additional
intercept_hook_point_post_kernelhook to the API that allows users to register a function to be called after a system call has been executed by the kernel by usingsyscall_no_intercept. In our case, this allows us to debug our interception layer, since we can now keep track of/log system call results for those syscalls where we don't really need to do anything. Since this has proved really useful to us, we thought it might be a worthwhile addition to the API.This change is