Skip to content

fix(ts-sdk): add missing fee field to UserTrade (#1983) #2019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
duna-akin wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

fix(ts-sdk): add missing fee field to UserTrade (#1983) #2019

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions sdks/typescript/pmxt/models.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,9 @@ export interface UserTrade {
/** Market ID */
marketId?: string;

/** Trading fee paid by the user for this fill, when the venue exposes it. */
fee?: number;

/** On-chain transaction hash (populated in hosted mode when the trade was settled on-chain). */
txHash?: string | null;

Expand Down