fix: use static JSON imports in ESM entry for bundler compatibility#6
Merged
fix: use static JSON imports in ESM entry for bundler compatibility#6
Conversation
createRequire resolves paths relative to import.meta.url, which
breaks when the module is bundled (e.g., by esbuild) because the
JSON files don't exist next to the bundle output. Static import
with { type: 'json' } allows bundlers to inline the JSON data.
ESLint's default parser doesn't support import attributes
(with { type: 'json' }) syntax yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createRequire+require('./allow.json')with staticimport ... with { type: 'json' }inindex.mjscreateRequire(import.meta.url)resolves paths relative to the importing file's URL, which breaks when bundled by esbuild — the JSON files don't exist next to the bundle outputTest plan