Remove Cloudflare Workers deployment steps from CI/CD#114
Merged
Conversation
Branch deploys were running `wrangler deploy` for auth-api and airscore-api workers without any environment flag, overwriting the production workers with potentially untested code. These workers only route to glidecomp.com anyway, so they were never reachable from preview URLs. https://claude.ai/code/session_01SsanzGQb7cr2RYmqNb7LpZ
Three changes to make Google OAuth work on Cloudflare Pages preview URLs: 1. Pages Function (functions/api/auth/[[path]].ts) proxies /api/auth/* to the auth-api worker via a service binding, so preview deployments can reach the auth worker regardless of domain. 2. Root wrangler.toml configures the Pages project with the AUTH_API service binding and switches deploys to `wrangler deploy` (which reads wrangler.toml) instead of `wrangler pages deploy`. 3. Better Auth oAuthProxy plugin + trustedOrigins wildcard so Google's OAuth callback on production forwards auth results back to the preview origin (e.g. *.glidecomp.pages.dev). https://claude.ai/code/session_01SsanzGQb7cr2RYmqNb7LpZ
wrangler deploy is the Workers command and doesn't accept --branch. wrangler pages deploy reads the project config from the root wrangler.toml. https://claude.ai/code/session_01SsanzGQb7cr2RYmqNb7LpZ
|
Preview Deployment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the automated deployment steps for Cloudflare Workers from the branch deployment workflow. The AirScore API Worker and Auth API Worker are no longer deployed through this CI/CD pipeline.
Changes
web/workers/airscore-apiweb/workers/auth-apicloudflare/wrangler-action@v3action with shared Cloudflare credentialsNotes
The frontend deployment to Cloudflare Pages and the "Output Preview URL" step remain unchanged. This change suggests that Cloudflare Workers deployments may now be handled through an alternative method or are no longer part of the automated deployment process.
https://claude.ai/code/session_01SsanzGQb7cr2RYmqNb7LpZ