Export interfaces and types#34
Open
jeppech wants to merge 1 commit intopokusew:masterfrom
jeppech:type-declation
Open
Export interfaces and types#34jeppech wants to merge 1 commit intopokusew:masterfrom jeppech:type-declation
jeppech wants to merge 1 commit intopokusew:masterfrom
jeppech:type-declation
Conversation
Author
|
@pokusew Could you please take a look at this? |
|
@pokusew could you maybe look into it? |
|
I needed some typings as well. The typings as in this PR did not work for me because this lib is not using es6 modules but the typings would require that. My solution for typings is as follows: Usage would be like this: I'm not sure if this project/pull request is still active. But I would appreciate if these or similar typings would make it into the project. If there is intrest I can provide a PR with these changes. |
|
This would be a very welcome change. I just copied the interface as of now.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've exported the types and interfaces. So they can be imported, and used within a project.
My reason for this is, that I need to put the readers in an array, for later use.