Make the module "Context Aware" (without the npm package changes)#48
Closed
danielduan wants to merge 4 commits intopokusew:masterfrom
LegitimateTech:master
Closed
Make the module "Context Aware" (without the npm package changes)#48danielduan wants to merge 4 commits intopokusew:masterfrom LegitimateTech:master
danielduan wants to merge 4 commits intopokusew:masterfrom
LegitimateTech:master
Conversation
Make the module "Context Aware" for newer versions of Electron and NodeJS
Author
|
@pokusew I'm not sure if you are still actively maintaining this repo but Electron v14+ require "Context Aware" native modules which means its not possible to use Let me know what else is needed, thanks! |
pokusew
added a commit
that referenced
this pull request
Sep 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the module "Context Aware" for newer versions of Electron and NodeJS
this is the exact changes from #45 but without the npm package name change and other edits. this should be ready to merge and publish when ready.