Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds diagnostic logging to troubleshoot Windows build issues related to version handling. The changes are specifically designed to test the behavior of the getSemverCompatibleVersion() function when encountering version strings with more than three parts.
Changes:
- Added console logging to the
getSemverCompatibleVersion()function to output the original version and warn when version conversion occurs - Modified the CI workflow to use a 4-part version string ("1.2.3.4") to trigger and test the version handling logic
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| script/package.ts | Adds debug logging to track version conversion for Windows compatibility with Squirrel.Windows |
| .github/workflows/ci.yml | Changes default version from "0.0.0" to "1.2.3.4" to trigger the version conversion code path |
pol-rivero
force-pushed
the
troubleshoot-windows-build
branch
from
04ef352 to
bdd460e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating this dummy PR to trigger the CI workflow without pushing to main