Open
Conversation
Me-k-01
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #300 +/- ##
==========================================
+ Coverage 94.07% 94.09% +0.02%
==========================================
Files 83 83
Lines 3323 3322 -1
Branches 267 267
==========================================
Hits 3126 3126
+ Misses 196 195 -1
Partials 1 1
🚀 New features to boost your workflow:
|
nmellado
reviewed
Mar 30, 2026
Comment on lines
+21
to
+23
| // rho prime is negative but the basket ignores negative weights | ||
| // (see Basket::addNeighbor()), so the opposite is returned here | ||
| // and Varifold::addLocalNeighbor() takes the opposite again |
Me-k-01
force-pushed
the
varifold
branch
10 times, most recently
from
c98faf4 to
456df0a
Compare
added 4 commits
April 13, 2026 11:41
Signed-off-by: fauberva <florian.auberval@irit.fr>
- Move `VarifoldWeightKernel` to the Weight Kernel file - Fix doc - Add Varifolds paper to bibitex - Fix PROVIDES Signed-off-by: fauberva <florian.auberval@irit.fr>
- Add missing end of line in bibitex Signed-off-by: fauberva <florian.auberval@irit.fr>
Signed-off-by: fauberva <florian.auberval@irit.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Readapted from pcloud-differential-estimation-benchmark
Changes made by this PR