[fitting] Add plane frame for base conversion#79
Open
jmaleo wants to merge 3 commits intoponcateam:masterfrom
Open
[fitting] Add plane frame for base conversion#79jmaleo wants to merge 3 commits intoponcateam:masterfrom
jmaleo wants to merge 3 commits intoponcateam:masterfrom
Conversation
nmellado
reviewed
May 31, 2023
Contributor
|
@jmaleo please fix compilation errors |
Contributor
|
Thanks, looks nice. One last remark: could you set |
|
Stale pull request message |
jmaleo
force-pushed
the
add_mean_plane
branch
from
59668af to
07c1129
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Me-k-01
force-pushed
the
add_mean_plane
branch
2 times, most recently
from
ed7ae7c to
7667c19
Compare
Me-k-01
previously approved these changes
Nov 24, 2025
nmellado
force-pushed
the
add_mean_plane
branch
from
c4e6bd1 to
706eaa5
Compare
Me-k-01
force-pushed
the
add_mean_plane
branch
from
706eaa5 to
811fcc9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #79 +/- ##
==========================================
+ Coverage 94.19% 94.38% +0.18%
==========================================
Files 76 79 +3
Lines 2704 2741 +37
Branches 223 224 +1
==========================================
+ Hits 2547 2587 +40
+ Misses 155 152 -3
Partials 2 2 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
nmellado
force-pushed
the
add_mean_plane
branch
from
811fcc9 to
abe8c63
Compare
Me-k-01
force-pushed
the
add_mean_plane
branch
2 times, most recently
from
abe8c63 to
a857e01
Compare
Me-k-01
changed the title
Contributor
|
Let's wait after we merged #195 |
- Rename `tangentPlaneToWorld` to `frameToWorld` and moved it to the `LocalFrame` class - Update `CovariancePlaneFitImpl`, `MongePatchFit` - Fix includes - Add `LocalFrameEstimator` to compute the normal - Update Provides with `PROVIDES_LOCAL_FRAME` - Add `localFrame.h` to `ponca_Fitting_INCLUDE` with cmake Signed-off-by: fauberva <florian.auberval@irit.fr>
Signed-off-by: fauberva <florian.auberval@irit.fr>
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: fauberva <florian.auberval@irit.fr>
Collaborator
|
Needs to wait for after the Fitting PR that will better separate the Computational structures from the Data owning structures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature adding the base conversion from plane created from oriented point clouds.
Fixes #239