Attach per-haplotype tip labels from the input VCF#48
Open
wnsplim wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently SINGER reads VCF genotypes positionally and discards the sample names, so the output has no tip labels (samples come out enumerated 0…n-1). This makes mapping results back to samples awkward for some downstream analyses.
We can re-attaches names from the input VCF when converting SINGER output to tskit: each diploid sample i (in VCF column order) becomes individual i with label set to the VCF sample name, and the two tips are named [sample]_0 & [sample]_1.
Edits:
If these should be handled differently, this PR can be dropped.