Skip to content

feat(sdk-value): expose ValueSyncPlugin#2457

Merged
rexxars merged 2 commits intomainfrom
feat/export-value-sync
Apr 3, 2026
Merged

feat(sdk-value): expose ValueSyncPlugin#2457
rexxars merged 2 commits intomainfrom
feat/export-value-sync

Conversation

@rexxars
Copy link
Copy Markdown
Member

@rexxars rexxars commented Apr 3, 2026

I have a use case where I want to customize the SDK sync behavior, but I don't want to re-implement the value sync machine logic. Not sure how "stable" you feel the API is: we could consider moving this to a separate plugin, plugin-value-sync or similar? This was the path of least resistance, but open to changing to your preferred approach @christianhg !

@rexxars rexxars requested a review from christianhg April 3, 2026 18:45
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Apr 3, 2026

🦋 Changeset detected

Latest commit: 7360855

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@portabletext/plugin-sdk-value Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
portable-text-editor-documentation Ready Ready Preview, Comment Apr 3, 2026 10:16pm
portable-text-example-basic Ready Ready Preview, Comment Apr 3, 2026 10:16pm
portable-text-playground Ready Ready Preview, Comment Apr 3, 2026 10:16pm

Request Review

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

📦 Bundle Stats — @portabletext/editor

Compared against main (ef6dabae)

@portabletext/editor

Metric Value vs main (ef6daba)
Internal (raw) 747.1 KB -
Internal (gzip) 140.8 KB -
Bundled (raw) 1.34 MB -
Bundled (gzip) 301.2 KB -
Import time 91ms -2ms, -2.5%

@portabletext/editor/behaviors

Metric Value vs main (ef6daba)
Internal (raw) 467 B -
Internal (gzip) 207 B -
Bundled (raw) 424 B -
Bundled (gzip) 171 B -
Import time 2ms -0ms, -2.3%

@portabletext/editor/plugins

Metric Value vs main (ef6daba)
Internal (raw) 2.5 KB -
Internal (gzip) 910 B -
Bundled (raw) 2.3 KB -
Bundled (gzip) 839 B -
Import time 8ms -0ms, -2.1%

@portabletext/editor/selectors

Metric Value vs main (ef6daba)
Internal (raw) 60.5 KB -
Internal (gzip) 9.5 KB -
Bundled (raw) 56.9 KB -
Bundled (gzip) 8.7 KB -
Import time 6ms +0ms, +0.5%

@portabletext/editor/utils

Metric Value vs main (ef6daba)
Internal (raw) 24.2 KB -
Internal (gzip) 4.7 KB -
Bundled (raw) 22.2 KB -
Bundled (gzip) 4.4 KB -
Import time 6ms -0ms, -0.5%

🗺️ . · ./behaviors · ./plugins · ./selectors · ./utils · Artifacts

Details
  • Import time regressions over 10% are flagged with ⚠️
  • Sizes shown as raw / gzip 🗜️. Internal bytes = own code only. Total bytes = with all dependencies. Import time = Node.js cold-start median.

Copy link
Copy Markdown
Member

@christianhg christianhg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with exporting/exposing it! And we can easily turn it into its own plugin later if we want to.

@christianhg
Copy link
Copy Markdown
Member

BTW, we need a changeset to trigger a release with this change (although not strictly needed if you want to keep it under the radar since the plugin gets a patch bump on every editor version bump.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants