Skip to content

Notify on merge queue failures#581

Merged
bschwedler merged 1 commit into
mainfrom
merge-queue
Jun 16, 2026
Merged

Notify on merge queue failures#581
bschwedler merged 1 commit into
mainfrom
merge-queue

Conversation

@bschwedler

Copy link
Copy Markdown
Contributor

The Slack notification action previously skipped silently when no prior
run history was found. Merge queue runs on ephemeral refs never appear
in a main-branch run query, so that guard was swallowing all merge queue
failures with no notification.

Now: no history + passing → still skip. No history + failing → notify.

@bschwedler bschwedler marked this pull request as ready for review June 9, 2026 18:40
@bschwedler bschwedler requested a review from ianpittwood as a code owner June 9, 2026 18:40
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

Test Results

1 894 tests  ±0   1 894 ✅ ±0   7m 53s ⏱️ +21s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 0d9bd00. ± Comparison against base commit 781830e.

♻️ This comment has been updated with latest results.

Comment thread .github/workflows/bakery-build-pr.yml Outdated
The action previously skipped silently when no previous workflow
runs were found on main. This prevented merge queue failures from
triggering notifications, since merge queue runs land on ephemeral
refs and never appear in a main-branch run query.

Now: no history + failed → fire failure notification; no history +
passed → skip. State-transition logic is unchanged for builds with
history.
@bschwedler bschwedler force-pushed the merge-queue branch 2 times, most recently from 8335041 to 0d9bd00 Compare June 16, 2026 19:31

@ianpittwood ianpittwood left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bschwedler bschwedler added this pull request to the merge queue Jun 16, 2026
Merged via the queue into main with commit c57c4a3 Jun 16, 2026
24 checks passed
@bschwedler bschwedler deleted the merge-queue branch June 16, 2026 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants