Filter ci matrix by dev-spec channel#624
Merged
Merged
Conversation
A dispatched dev build folds its channel into the --dev-spec JSON, and the shared CI workflow then stops passing --dev-channel. bakery ci matrix filtered only by the explicit --dev-channel option, so a single-channel dispatch still emitted every channel's dev version. Only the matching channel got its version pinned. The others resolved to their channel head, producing surprise extra builds. Derive the matrix channel filter from the dev-spec channel when --dev-channel is absent. This matches the channel that _apply_dev_spec already uses to pin the version, so the filter and the pin agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A dispatched dev build puts its channel in the
--dev-specJSON, and the shared workflow then stops passing--dev-channel.bakery ci matrixonly filtered by--dev-channel, so a single-channel dispatch still built every channel's dev version. Only the dispatched channel got its version pinned, and the rest resolved to their channel head.ci matrixnow uses the dev-spec channel as the filter when--dev-channelis absent, so the filter and the pin agree.