Path as target#10
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for scanning a flat “target” directory (e.g., pip install --target <dir>) directly, instead of requiring a full virtual environment layout, by introducing a path_as_target flag on get_packages_from_env.
Changes:
- Extend
get_packages_from_envwithpath_as_targetto scan the provided directory directly (skipping venv layout,.pth, system, andPYTHONPATHdiscovery). - Add unit tests covering target-directory scanning behavior and ensuring
.pth/PYTHONPATHare ignored in this mode. - Document the new target-directory scanning mode in the README.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
src/picopip.py |
Adds path_as_target option to scan venv_path as a direct package directory. |
tests/test_packages_discovery.py |
Adds tests validating target-directory scanning and its isolation from .pth/PYTHONPATH. |
README.md |
Documents path_as_target=True usage for pip install --target directories. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for scanning a
--targetdirectory instead of a virtual environment