Skip to content

Reticulate: Recover tests #11232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dfalbel merged 2 commits into from
Jan 7, 2026
Merged

Reticulate: Recover tests #11232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8582561
Enable reticulate tests
dfalbel Jan 5, 2026
49b583f
Fix reticulate support on linux
dfalbel Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions extensions/positron-python/python_files/posit/positron/positron_ipkernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -643,6 +643,24 @@ def _showwarning(self, message, category, filename, lineno, file=None, line=None

return original_showwarning(message, category, filename, lineno, file, line) # type: ignore reportAttributeAccessIssue

def pre_handler_hook(self):
# Override the default pre_handler_hook to add debug logging.
# The default logging in Ipykernel adds the exc_info=True which is causing
# huge tracebacks, specially in reticulate sessions - the pre_handler_hook and
# post_handler_hook always fail because they can't signal from a different thread.
# See: https://github.com/posit-dev/positron/issues/10953
try:
super().pre_handler_hook()
except Exception as e:
self.log.debug("Error in super().pre_handler_hook(): %s", e, exc_info=False)

def post_handler_hook(self):
# see the pre_handler_hook for details
try:
super().post_handler_hook()
except Exception as e:
self.log.debug("Error in super().post_handler_hook(): %s", e, exc_info=False)


class PositronIPKernelApp(IPKernelApp):
control_thread: ControlThread | None
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/tests/reticulate/reticulate-multiple.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ test.use({
// RETICULATE_PYTHON
// to the installed python path

test.describe.skip('Reticulate', {
test.describe('Reticulate', {
tag: [tags.RETICULATE, tags.WEB, tags.ARK, tags.SOFT_FAIL],
}, () => {
test.beforeAll(async function ({ app, settings }) {
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/tests/reticulate/reticulate-repl-python.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ test.use({
// RETICULATE_PYTHON
// to the installed python path

test.describe.skip('Reticulate', {
test.describe('Reticulate', {
tag: [tags.RETICULATE, tags.WEB, tags.ARK, tags.SOFT_FAIL],
}, () => {
test.beforeAll(async function ({ app, settings }) {
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/tests/reticulate/reticulate-restart.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ test.use({
// RETICULATE_PYTHON
// to the installed python path

test.describe.skip('Reticulate', {
test.describe('Reticulate', {
tag: [tags.RETICULATE, tags.WEB, tags.SOFT_FAIL],
}, () => {
test.beforeAll(async function ({ app, settings }) {
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/tests/reticulate/reticulate-stop-start.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ test.use({
// RETICULATE_PYTHON
// to the installed python path

test.describe.skip('Reticulate', {
test.describe('Reticulate', {
tag: [tags.RETICULATE, tags.WEB, tags.SOFT_FAIL],
}, () => {
test.beforeAll(async function ({ app, settings }) {
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/tests/reticulate/reticulate-variables.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ test.use({
// In order to run this test on Windows, I think we need to set the env var:
// RETICULATE_PYTHON to the installed python path

test.describe.skip('Reticulate - Variables pane support', {
test.describe('Reticulate - Variables pane support', {
tag: [tags.RETICULATE, tags.WEB, tags.SOFT_FAIL],
}, () => {
test('R - Verify Reticulate formats variables in the Variables pane', async function ({ app, sessions, logger }) {
Expand Down