fix: clarify Connect uses npm in Node.js lockfile error#787
Merged
Conversation
|
The "No package-lock.json found" error raised when deploying Node.js content now states that Connect installs Node.js dependencies with npm, so publishers who build with yarn or pnpm understand why the lock file is required. Part of posit-dev/connect#40767 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
dotNomad
force-pushed
the
dotnomad/nodejs-npm-error-messaging
branch
from
ff64221 to
2131496
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
karawoo
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
A publisher who builds a Node.js project with yarn or pnpm has no
package-lock.json, sorsconnect deploy nodejsfails with an error that asks forpackage-lock.jsonwithout explaining that Connect specifically requiresnpm. This adds that clarification.Type of Change
Approach
rsconnect/environment_node.py: theNodeEnvironment.createlockfile check now adds the sentence "Connect installs Node.js dependencies with npm." to the raisedRSConnectException. The message is unconditional - noyarn.lock/pnpm-lock.yamldetection - so it reads correctly in every case.Automated Tests
tests/test_environment_node.py::test_create_no_lock_filenow asserts the exception text includes the npm clarification.Directions for Reviewers
In a Node.js project directory with a
package.jsonbut nopackage-lock.json, runrsconnect deploy nodejs. The error names npm as the package manager Connect uses.Checklist
rsconnect-python-tests-at-nightworkflow in Connect against this feature branch.