fix(nodejs): add python env exclusion for nodejs manifest generation#789
Merged
Conversation
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
dotNomad
approved these changes
Jun 22, 2026
dotNomad
left a comment
dotNomad
left a comment
Contributor
There was a problem hiding this comment.
Very clean and very easy approval ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exculde python env files in nodejs manifest generation.
Intent
resolves #783
Type of Change
Approach
make_nodejs_manifestonly excludedmanifest.jsonandnode_modules. It needs to also exclude python env files. Every other content generator strips these vialist_environment_dirs(...)so we just have to do that here as wellAutomated Tests
test_manifest_excludes_python_virtual_environmentcreates a venv-shaped .venv and asserts none of its files appear in the manifest. Confirmed it fails without the fix and passes with it.Directions for Reviewers
Checklist
rsconnect-python-tests-at-nightworkflow in Connect against this feature branch.