fix(pkg-py): resolve circular import on import shinychat#212
Merged
Conversation
… shiny's init (#207) The import chain `shinychat` → `_chat_bookmark` → `shiny.types` → `shiny.__init__` → `shiny.ui._chat` → `shinychat` caused a circular import error because `shinychat` was still initializing. Defer the `shiny.types.Jsonifiable` import to `TYPE_CHECKING` since it's only used in annotations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #207
Summary
import shinychatfailed with a circular import whenshinywas installed, because_chat_bookmark.pyimportedshiny.types.Jsonifiableat module level — triggeringshiny.__init__→shiny.ui._chat→from shinychat import Chatbeforeshinychatfinished initializing.shiny.types.Jsonifiableimport toTYPE_CHECKING(it's only used in annotations) and addedfrom __future__ import annotationsto_chat_bookmark.py.Test plan
python -c "import shinychat"succeedsuv run pyrightpasses (0 errors)uv run pytest pkg-py/tests/pytest/test_import.pypasses