Conversation
babababag
commented
Jan 22, 2022
| @@ -202,11 +202,18 @@ fallthrough a ft = | |||
| -- NOTE(dbp 2015-11-05): This list taken from snap-core, BSD3 licensed. | |||
Author
There was a problem hiding this comment.
technically this comment is not as true anymore
Member
There was a problem hiding this comment.
Good point, could you just add a second comment beneath this one with your initials making it clear that you've expanded on the original list?
Member
|
@babababag Thanks for the PR and sorry for the delay in reviewing it! |
emhoracek
requested changes
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to just add webp but why not others. Also changed some of them to match the official IANA doc. The new ones are from https://developer.mozilla.org/en-US/docs/Web/HTTP/Basics_of_HTTP/MIME_types/Common_types.